chore(shortint): new parameters #1886

nsarlin-zama · 2024-12-17T11:10:17Z

No description provided.

soonum · 2024-12-20T13:17:56Z

Should we set aliases for Gaussian common parameters (like 2_2) just like the Tuniform flavour ? @IceTDrinker
We could do it in a different PR as is not changing directly the behavior of the current implementation.

soonum

Incredible and tedious job, thanks a lot @nsarlin-zama !

tfhe/src/shortint/parameters/compact_public_key_only/p_fail_2_minus_64/ks_pbs.rs

tfhe/src/shortint/parameters/key_switching/p_fail_2_minus_64/ks_pbs.rs

nsarlin-zama · 2025-01-03T16:49:58Z

I added a new enum inside the CompactPublicKeyEncryptionParameters: SupportedCompactPkeZkScheme. It can take 3 values: ZkNotSupported, V1 and V2.
ZkNotSupported is used when pke parameters are derived from compute paramters and we cannot guess the correct zk version to use.

V1 params will always generate a V1 crs and V2 params a V2 crs, which will make incompatibility issues less likely. However, since the zk version is not stored in the keyswitch paramters, it is still possible to mix pke parameters for v2 with keyswitch parameters for v1.

BREAKING_CHANGE: - Zk for compact PKE now requires dedicated encryption parameters

IceTDrinker · 2025-01-06T18:01:31Z

apps/trivium/benches/kreyvium_shortint.rs

-        gen_keys(PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64);
+        gen_keys(V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64);


huh I think this is not correct as the ConfigBuilder is using the default config, not required to change for the release tomorrow, this is purely at the GitHub repo level, please make a note to look for ConfigBuilder::default() usage

I'm missing something, but this is just a rename ?

I think the regression was introduced in a previous pr, so yeah we might as well fix it in another pr if that's not blocking for the release

the default params for the config is TUniform I believe so the config above in the code (read the full source) should be changed, this parameter set for keyswitch does not match, can be done in a follow up PR

I agree but the change to tuniform is not from this PR

IceTDrinker · 2025-01-06T18:01:53Z

apps/trivium/benches/trivium_shortint.rs

-        gen_keys(PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64);
+        gen_keys(V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64);


same story here

IceTDrinker · 2025-01-06T18:02:13Z

apps/trivium/src/kreyvium/test.rs

-use tfhe::shortint::parameters::PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64;
+use tfhe::shortint::parameters::V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64;


same thing here most likely as well

IceTDrinker · 2025-01-06T18:04:08Z

apps/trivium/src/trivium/test.rs

-use tfhe::shortint::parameters::PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64;
+use tfhe::shortint::parameters::V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64;


her as well

IceTDrinker · 2025-01-06T18:05:48Z

tfhe/benches/shortint/bench.rs

+    V0_11_PARAM_MESSAGE_1_CARRY_0_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_2_CARRY_0_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_2_CARRY_1_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_2_CARRY_2_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_3_CARRY_0_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_3_CARRY_2_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_3_CARRY_3_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_4_CARRY_0_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_4_CARRY_3_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_4_CARRY_4_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_5_CARRY_0_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_6_CARRY_0_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_7_CARRY_0_KS_PBS_GAUSSIAN_2M64,
+    V0_11_PARAM_MESSAGE_8_CARRY_0_KS_PBS_GAUSSIAN_2M64,


@soonum will this break benchmark displays in Grafana ?

we may need to be a bit more flexible on parameter names to authorize the prefix v_something

IceTDrinker · 2025-01-07T09:37:42Z

apps/trivium/benches/kreyvium_shortint.rs

-        gen_keys(PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64);
+        gen_keys(V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64);


the default params for the config is TUniform I believe so the config above in the code (read the full source) should be changed, this parameter set for keyswitch does not match, can be done in a follow up PR

cla-bot bot added the cla-signed label Dec 17, 2024

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch 2 times, most recently from 25d6bb9 to 92ea542 Compare December 17, 2024 15:07

nsarlin-zama requested a review from tmontaigu December 17, 2024 15:28

tmontaigu approved these changes Dec 18, 2024

View reviewed changes

zama-bot added the approved label Dec 18, 2024

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch from 92ea542 to e7273ab Compare December 19, 2024 15:09

zama-bot removed the approved label Dec 19, 2024

nsarlin-zama changed the title ~~chore(shortint): new parameters for zkv1~~ chore(shortint): new parameters Dec 19, 2024

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch 4 times, most recently from 7858942 to b173358 Compare December 20, 2024 08:53

nsarlin-zama requested a review from soonum December 20, 2024 08:59

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch 2 times, most recently from 9b313f2 to 0fab62b Compare December 20, 2024 10:41

soonum approved these changes Dec 20, 2024

View reviewed changes

zama-bot added the approved label Dec 20, 2024

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch from a26e7fc to 325fe6e Compare December 20, 2024 16:49

zama-bot removed the approved label Dec 20, 2024

nsarlin-zama added the approved label Dec 20, 2024

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch from 325fe6e to 9aba56b Compare January 2, 2025 11:06

zama-bot removed the approved label Jan 2, 2025

nsarlin-zama requested a review from IceTDrinker January 2, 2025 11:11

IceTDrinker reviewed Jan 2, 2025

View reviewed changes

tfhe/src/shortint/parameters/compact_public_key_only/p_fail_2_minus_64/ks_pbs.rs Show resolved Hide resolved

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch from 9aba56b to 4ba654b Compare January 3, 2025 08:56

IceTDrinker reviewed Jan 3, 2025

View reviewed changes

tfhe/src/shortint/parameters/key_switching/p_fail_2_minus_64/ks_pbs.rs Show resolved Hide resolved

nsarlin-zama added 2 commits January 3, 2025 13:39

chore(shortint): new parameters for tuniform

3432b94

chore(zk): add a test with zkv1 in integer compact list encryption

d89c93c

nsarlin-zama added 7 commits January 3, 2025 13:39

chore(shortint): rename wopbs params to LEGACY_

4a23eb4

chore(shortint): remove tuniform pbs_ks parameters

3f420f4

chore(shortint): update gaussian compact pk parameters

387c907

chore(shortint): update classic gaussian param

531d71a

chore(shortint): update multibit gaussian parameters

1cd88c8

chore(shortint): re-export v0.10 params at top level

8676a65

chore(shortint): move tuniform 0.10 parameters into their own folder

f1eb675

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch from 4ba654b to d8c0f9d Compare January 3, 2025 16:41

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch 6 times, most recently from 48e87b8 to 7303b32 Compare January 6, 2025 16:21

nsarlin-zama added the approved label Jan 6, 2025

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch from 7303b32 to 4175aea Compare January 6, 2025 17:51

zama-bot removed the approved label Jan 6, 2025

nsarlin-zama added 3 commits January 6, 2025 18:54

chore(zk)!: store inside the pke params the supported zk scheme

a2a54a4

BREAKING_CHANGE: - Zk for compact PKE now requires dedicated encryption parameters

chore(shortint): update keyswitch 1_1 to 2_2 parameters

71fb6c5

chore(shortint): update compression parameters

3667154

nsarlin-zama force-pushed the ns/chore/params_zkv1 branch from 4175aea to 3667154 Compare January 6, 2025 17:54

nsarlin-zama added the approved label Jan 6, 2025

IceTDrinker reviewed Jan 6, 2025

View reviewed changes

IceTDrinker approved these changes Jan 7, 2025

View reviewed changes

nsarlin-zama merged commit 3c3e2d7 into main Jan 7, 2025
106 of 119 checks passed

nsarlin-zama deleted the ns/chore/params_zkv1 branch January 7, 2025 11:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(shortint): new parameters #1886

chore(shortint): new parameters #1886

nsarlin-zama commented Dec 17, 2024

soonum commented Dec 20, 2024 •

edited

Loading

soonum left a comment

nsarlin-zama commented Jan 3, 2025

IceTDrinker Jan 6, 2025

nsarlin-zama Jan 7, 2025

nsarlin-zama Jan 7, 2025

IceTDrinker Jan 7, 2025

nsarlin-zama Jan 7, 2025

IceTDrinker Jan 7, 2025

IceTDrinker Jan 6, 2025

IceTDrinker Jan 6, 2025

IceTDrinker Jan 6, 2025

IceTDrinker Jan 6, 2025

IceTDrinker Jan 7, 2025

		gen_keys(PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64);
		gen_keys(V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64);

		use tfhe::shortint::parameters::PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64;
		use tfhe::shortint::parameters::V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64;

chore(shortint): new parameters #1886

chore(shortint): new parameters #1886

Conversation

nsarlin-zama commented Dec 17, 2024

soonum commented Dec 20, 2024 • edited Loading

soonum left a comment

Choose a reason for hiding this comment

nsarlin-zama commented Jan 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soonum commented Dec 20, 2024 •

edited

Loading